Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gofumpt the repo #3067

Merged
merged 2 commits into from
Jun 25, 2024
Merged

gofumpt the repo #3067

merged 2 commits into from
Jun 25, 2024

Conversation

dprotaso
Copy link
Member

gofumpt'd the codebase

https://github.com/mvdan/gofumpt

@knative-prow knative-prow bot requested review from aslom and Cali0707 June 21, 2024 20:46
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@knative-prow knative-prow bot requested a review from creydr June 21, 2024 20:46
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (51dec91) to head (9504615).
Report is 1 commits behind head on main.

Files Patch % Lines
test/request.go 0.00% 3 Missing ⚠️
apis/duck/v1/source_types.go 0.00% 1 Missing ⚠️
apis/duck/v1beta1/source_types.go 0.00% 1 Missing ⚠️
configmap/hash-gen/main.go 0.00% 1 Missing ⚠️
network/h2c.go 0.00% 1 Missing ⚠️
profiling/server.go 0.00% 1 Missing ⚠️
test/clients.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   78.43%   78.42%   -0.02%     
==========================================
  Files         191      191              
  Lines        8934     8939       +5     
==========================================
+ Hits         7007     7010       +3     
- Misses       1665     1666       +1     
- Partials      262      263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/assign @ReToCode @skonto @pierDipi

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
Copy link

knative-prow bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8535fcc into knative:main Jun 25, 2024
41 checks passed
@dprotaso dprotaso deleted the gofumptd branch June 25, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants